feat: re-export CodecValue and DecodedMessage at top level #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can now use robocodec::CodecValue and robocodec::DecodedMessage directly instead of robocodec::core::value::CodecValue.
Greptile OverviewGreptile SummaryThis PR makes two commonly-used public types easier to import by re-exporting
|
| Filename | Overview |
|---|---|
| src/lib.rs | Re-exports CodecValue and DecodedMessage from core::value at the crate root and updates docs/examples to use robocodec::{CodecValue, DecodedMessage}; no functional issues found. |
Sequence Diagram
sequenceDiagram
participant User as Library user
participant RC as robocodec (crate root)
participant Core as robocodec::core
participant Val as robocodec::core::value
User->>RC: use robocodec::{CodecValue, DecodedMessage}
RC-->>User: re-exported types available
RC->>Val: pub use core::value::{CodecValue, DecodedMessage}
Val-->>RC: resolve types
User->>Core: (still available) use robocodec::core::{CodecValue, DecodedMessage}
Core-->>User: same types
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CodecValueandDecodedMessageat the top level ofrobocodeccraterobocodec::CodecValueandrobocodec::DecodedMessagedirectlyMotivation
Previously, users had to use the longer path
robocodec::core::value::CodecValueor import viarobocodec::core::{CodecValue, DecodedMessage}. This change makes these commonly-used types more accessible at the top level.Changes
pub use core::value::{CodecValue, DecodedMessage};tosrc/lib.rsDecodedMessageandCodecValue